Fix named string round-trip diagnostic guidance

[Copilot]

stringbytesroundtrip matched named string/byte-slice types by underlying type but hardcoded diagnostics as string([]byte(...)) and implied both conversions were always removable.

• Diagnostics

  • Render actual outer and inner conversion syntax.
  • Recommend a direct outer conversion when named string types require it.
  • Retain “both conversions can be removed” only for exact string inputs/results.

• Documentation

  • Clarify named-type round trips may require the outer conversion.

• Coverage

  • Add named outer conversion and string return-context cases.

type myString string

return string([]byte(ms))
// diagnostic: replace it with string(ms)

_ = myString([]byte(ms))
// diagnostic: replace it with myString(ms)

• Fixes stringbytesroundtrip: redundant-round-trip message hardcodes "string(...)"/"[]byte(...)" and ignores named-type assignability, g [Content truncated due to length] #52826

[github-actions]

Great work on the stringbytesroundtrip linter fix! 🎯 This PR improves diagnostic accuracy for named string types, which is exactly what the linter ecosystem needs.

The changes here:

• Enhanced diagnostics — now render actual conversion syntax and distinguish between exact string types and named string types
• Accurate guidance — recommends the outer conversion when named types require it
• Solid test coverage — new test cases cover both the myString([]byte(ms)) pattern and the string([]byte(ms)) return-context case

Everything aligns with the project's linter quality standards: focused, well-documented, properly tested. This looks ready for review and merge. ✅

Generated by ✅ Contribution Check · auto · 57.4 AIC · ⌖ 3.95 AIC · ⊞ 9.1K · ◷

[Copilot]

Pull request overview

Improves stringbytesroundtrip diagnostics for named string types and clarifies conversion-removal guidance.

Changes:

• Renders actual conversion syntax in diagnostics.
• Preserves necessary outer conversions for named types.
• Adds named-type and return-context coverage.

Show a summary per file

File	Description
pkg/linters/stringbytesroundtrip/stringbytesroundtrip.go	Updates documentation and diagnostic generation.
pkg/linters/stringbytesroundtrip/testdata/src/stringbytesroundtrip/stringbytesroundtrip.go	Adds named conversion test cases.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Balanced

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.0