Broaden empty-catch intent comment recognition - #52983
Merged
Merged
Conversation
5 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix comment regex for no-empty-catch-block rule
Broaden empty-catch intent comment recognition
Aug 15, 2026
pelikhan
marked this pull request as ready for review
August 15, 2026 23:36
Contributor
There was a problem hiding this comment.
Pull request overview
Broadens ESLint empty-catch intent detection while preserving rejection of vague or negated comments.
Changes:
- Adds recognized intent phrases and negation safeguards.
- Adds positive and negative regression cases.
Show a summary per file
| File | Description |
|---|---|
no-empty-catch-block.ts |
Expands comment recognition logic. |
no-empty-catch-block.test.ts |
Covers new intent and negation phrases. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
| const sourceCode = context.sourceCode; | ||
| const intentionalIgnoreCommentRe = /\bintentional\b|\bbest[- ]effort\b|\bnon[- ]fatal\b|\bsilently swallow(?:ed|s|ing)?\b/i; | ||
| const intentionalIgnoreCommentRes = [/\bintentional\b/i, /\bbest[- ]effort\b/i, /\bnon[- ]fatal\b/i, /(?<![-\w])(?:safe to )?ignore(?:d|s)?\b/i, /\bfall[- ]through\b/i, /\bno[- ]?op\b/i]; | ||
| const negatedIntentionalIgnoreCommentRe = /\b(?:can't|cannot|do not|don't|must not|never|not|should not)\s+(?:an?\s+)?(?:(?:safe to\s+)?ignore|(?:silently\s+)?swallow|fall[- ]through|no[- ]?op|best[- ]effort|non[- ]fatal)\b/i; |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no-empty-catch-blockwas only accepting a narrow set of intent-signaling comments, causing documented no-op catches such as non-fatal cleanup and JSON parse fallthrough handling to be reported.Intent vocabulary
non-fatal,ignore/ignored,fall through,no-op,safe to ignore, and constrainedswallowphrasing.Negation safeguards
do not ignore,can't ignore,do not fall through, ornot a no-op.Regression coverage