Constrain go-logger candidate selection to prevent agent timeout - #53302
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Go Logger enhancement workflow failure
Constrain go-logger candidate selection to prevent agent timeout
Aug 17, 2026
Contributor
PR TriageCategory: bug | Risk: low | Score: 35/100
Recommended action: batch_review (grouped with #53301, #53300 as small workflow/agent fixes)
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds bounded candidate-selection guidance to prevent Go Logger Enhancement workflow timeouts.
Changes:
- Restricts discovery to the manifest and at most five files.
- Regenerates the workflow lock metadata.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/go-logger.md |
Adds deterministic selection instructions. |
.github/workflows/go-logger.lock.yml |
Updates the compiled body hash. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
| - Do **not** launch sub-agents for file discovery or complexity scoring. | ||
| - Do **not** scan `pkg/` broadly once `manifest.json` is available. | ||
| - Select files only from `files_needing_logger` in `manifest.json`. | ||
| - If more than 5 files are listed, take the first 5 entries and continue directly to edits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go Logger Enhancement workflow was failing because the Claude run drifted into broad exploratory reads, exhausted tokens, and hit the 15-minute engine timeout before making actionable edits. This change tightens the workflow prompt to keep selection deterministic and bounded.
Root-cause containment in workflow instructions
.github/workflows/go-logger.md(1.5. Keep Selection Deterministic and Bounded) to explicitly prevent unbounded discovery behavior.Deterministic file-selection contract
pkg/scanning once preflight manifest data exists.manifest.json(files_needing_logger).Compiled workflow update
.github/workflows/go-logger.lock.ymlfrom the markdown source so runtime behavior matches the updated prompt.