Add shared AdaL agentic engine and smoke workflow#53309
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
PR TriageCategory: feature (OpenTelemetry-related) | Risk: high | Score: 53/100
Recommended action: fast_track This PR touches OpenTelemetry/telemetry normalization — per triage policy it should be assigned to
|
|
Thanks for adding the AdaL agentic engine integration! 🎉 This PR aligns well with the project's agentic-first development model and adds a clearly defined new capability. What Looks Good
Suggestions for Strengthening This PRAdd unit test coverage — While the smoke workflow provides integration-level validation, consider adding traditional unit or integration tests for the AdaL harness logic, especially around:
This would make the PR even more robust and easier for future maintainers to understand and modify the AdaL integration. Consider adding edge-case validation — If the PR doesn't already cover error handling (e.g., missing auth token, malformed NDJSON), add tests for those scenarios. If you'd like help adding these tests, you can assign this prompt to your coding agent:
|
There was a problem hiding this comment.
Pull request overview
Adds AdaL as a reusable agentic engine with a private smoke workflow.
Changes:
- Defines AdaL authentication, execution, networking, and telemetry parsing.
- Adds and compiles the
/smoke-adalworkflow. - Registers AdaL in engine and slash-command catalogs.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/shared/adal.md |
Defines the AdaL engine. |
.github/workflows/smoke-adal.md |
Adds smoke-test coverage. |
.github/workflows/smoke-adal.lock.yml |
Contains the compiled workflow. |
.github/workflows/agentic_commands.yml |
Registers /smoke-adal. |
.github/aw/engines.json |
Adds AdaL to the engine catalog. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 2
- Review effort level: Balanced
|
|
||
| ## Test Requirements | ||
|
|
||
| 1. **File Writing Testing**: Create a test file `/tmp/gh-aw/agent/smoke-test-adal-${{ github.run_id }}.txt` with content "Smoke test passed for AdaL" (create the directory if it doesn't exist) |
| log-parser: | | ||
| function parseLog(logContent) { |
Adds AdaL CLI as a reusable definition-based agentic engine with a private smoke workflow.
Changes
Shared engine
@sylphai/adal-cli1.7.0.ADAL_AUTH_TOKENfor headless authentication.adal/modelnames and prompt delivery through a secure harness.Smoke coverage
/smoke-adalfor prompt, model, file-editing, shell, repository, and safe-output validation.