Add review-agentic-workflows skill for security-first workflow review and optimization triage - #53775
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
review-agentic-workflows skill for security-first workflow review and optimization triage
|
|
||
| Run these checks before reviewing: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
@copilot use the bash script to install the cli
There was a problem hiding this comment.
Updated in 435a4c6. The setup now uses bash ./install-gh-aw.sh to install gh aw when it is missing, with fallback handling if the installer script is unavailable.
| Identify changed workflow sources and generated outputs: | ||
|
|
||
| ```bash | ||
| BASE_REF="${BASE_REF:-origin/main}" |
|
|
||
| Run these checks before reviewing: | ||
|
|
||
| ```bash |
| If `gh aw` extension is unavailable but local binary exists: | ||
|
|
||
| ```bash | ||
| ./gh-aw compile --strict --actionlint --zizmor --poutine --runner-guard --yamllint |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
PR Triage
Draft adding a new review-agentic-workflows skill. Already has 5 reviews. Low risk; undraft to proceed to merge track.
|
|
|
||
| ### Step 0) Verify repository and install CLI when missing | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
Implemented in 080c574. I extracted the setup/install logic into .github/skills/review-agentic-workflows/setup.sh and updated SKILL.md Step 0 to call that script.
|
|
||
| ### 3) Enforce security best practices | ||
|
|
||
| Require and verify: |
There was a problem hiding this comment.
@copilot add an explicit reference to the agentic workflow skill .md file using a github raw user content url.
There was a problem hiding this comment.
Implemented in 2cc4187. Added an explicit GitHub rawusercontent URL reference to .github/skills/agentic-workflows/SKILL.md in .github/skills/review-agentic-workflows/SKILL.md.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
| @@ -0,0 +1,35 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
@copilot do not reimplement setup, use the install-aw.sh file in main.
There was a problem hiding this comment.
Updated in 4e6d7d4. .github/skills/review-agentic-workflows/setup.sh now uses the repository root ./install-gh-aw.sh installer instead of reimplementing setup/install flow in the skill script.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot remove setup.sh and instead prompt the user to test if gh aw is installed or run the bash scripts steps from the gh-aw repo |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Updated in 5d39ee2. I removed |
There was a problem hiding this comment.
Pull request overview
Adds a security-first playbook for reviewing agentic workflows and makes it discoverable through repository skill routing.
Changes:
- Adds workflow security, validation, and optimization review guidance.
- Routes relevant reviews to the new skill.
Show a summary per file
| File | Description |
|---|---|
AGENTS.md |
Registers the new review skill. |
.github/skills/review-agentic-workflows/SKILL.md |
Defines the review playbook and commands. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 4
- Review effort level: Balanced
| # Review Agentic Workflows | ||
|
|
||
| Use this skill when asked to review `.github/workflows/*.md` agentic workflows or their generated `.lock.yml` outputs. | ||
| Reference workflow authoring skill guidance at: https://raw.githubusercontent.com/github/gh-aw/main/.github/skills/agentic-workflows/SKILL.md |
| if gh aw --help >/dev/null 2>&1; then | ||
| echo "gh aw is installed" | ||
| else | ||
| if [ -f ./install-gh-aw.sh ]; then | ||
| echo "gh aw is missing. Run the install step before continuing:" | ||
| echo " bash ./install-gh-aw.sh" | ||
| echo "Then verify:" | ||
| echo " gh aw --help" | ||
| else | ||
| echo "gh aw is missing and ./install-gh-aw.sh is not present in this checkout." | ||
| fi | ||
| return 1 2>/dev/null || exit 1 | ||
| fi |
| BASE_REF="${BASE_REF:-origin/main}" | ||
| if git rev-parse --verify "$BASE_REF" >/dev/null 2>&1; then | ||
| git diff --name-only "$BASE_REF...HEAD" -- .github/workflows/ | ||
| else | ||
| git diff --name-only -- .github/workflows/ | ||
| fi |
|
|
||
| ```bash | ||
| gh aw audit <run-id-or-url> | ||
| gh aw logs --start-date -14d --workflow-name <workflow-name> |
|
🎉 This pull request is included in a new release. Release: |
This PR adds a dedicated skill for reviewing agentic workflow changes end-to-end, with explicit focus on catching security regressions and surfacing optimization opportunities from run evidence. It also wires the skill into repository-level skill routing so it is discoverable by intent.
New skill:
review-agentic-workflows.github/skills/review-agentic-workflows/SKILL.mdas a self-contained review playbook.Security regression detection hardening
Run-history optimization guidance
gh aw audit/gh aw logsanalysis when run IDs/history are available.Skill routing integration
AGENTS.mdto map security-focused agentic workflow review tasks to the new skill.