[test-parallel] test: add missing t.Parallel() in codemod_mcp_network_addallowed_test.go

[github-actions]

Summary

Analyzed a batch of 25 pkg/cli/codemod_*_test.go files (round-robin, resuming after pkg/cli/codemod_difc_proxy_test.go) for safe t.Parallel() additions.

Analysis

24 of 25 files already had t.Parallel() on every top-level test and eligible subtest. One subtest in codemod_mcp_network_addallowed_test.go was missing it:

• TestAddAllowedToNetwork/comment line inside network block is skipped, then top-level sibling ends the block

This subtest only operates on local slices/strings via the pure addAllowedToNetwork function — no env vars, globals, shared filesystem paths, or external services — so it is safe to parallelize alongside its sibling subtests.

pkg/cli/codemod_factory_test.go was flagged unsafe due to a shared package-level logger (testFactoryLog) reused across tests, so it was left unchanged.

Validation

• go test -race ./pkg/cli/ -run TestAddAllowedToNetwork -v — PASS
• go test ./pkg/cli/... -run TestAddAllowedToNetwork — PASS

State

Cache updated to pkg/cli/codemod_messages_effective_tokens_suffix_to_ai_credits_suffix_pure_test.go (last file in this batch) for the next daily run.

Generated by Daily Go Test Parallelizer · copilot · auto · 43.6 AIC · ⌖ 8.26 AIC · ⊞ 8.6K · ◷

• expires on Aug 31, 2026, 1:54 PM UTC-08:00

[github-actions]

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

No ADR enforcement needed: PR does not have the 'implementation' label and has <=100 new lines of code in business logic directories.

🏗️ ADR gate enforced by Design Decision Gate 🏗️

[github-actions]

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

[github-actions]

⚠️ Security scanning failed for Ponytail Reviewer. Review the logs for details.

Lean already. Ship.

Warning

Firewall blocked 4 domains

The following domains were blocked by the firewall during workflow execution:

• ab.chatgpt.com
• api.github.com
• chatgpt.com
• github.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"
    - "api.github.com"
    - "chatgpt.com"
    - "github.com"

See Network Configuration for more information.

Generated by Ponytail Reviewer for #56714

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

[github-actions]

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

[github-actions]

Comment Memory

reviewed_at: 2026-08-28T00:00:00Z
review_event: COMMENT
top_themes:
  - no actionable issues
files_reviewed:
  - pkg/cli/codemod_mcp_network_addallowed_test.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · pi · gpt54 · 2 AIC · ⌖ 7.3 AIC · ⊞ 7K · ◷
_{Comment /review to run again}

[github-actions]

Verdict

Non-blocking: this change only adds t.Parallel() to an isolated subtest, and the touched test body uses only local data with no shared mutable state.

Themes reviewed

• parallel test safety and shared-state hazards
• changed-line correctness impact
• need for additional coverage around the new parallelization point

I did not find an actionable correctness, concurrency, or maintainability issue in the changed lines.

🔎 Code quality review by PR Code Quality Reviewer · pi · gpt54 · 2 AIC · ⌖ 7.3 AIC · ⊞ 7K
_{Comment /review to run again}

[github-actions]

LGTM — straightforward addition of the missing t.Parallel() to keep the subtest consistent with its siblings.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · copilot · sonnet46 · 13.2 AIC · ⌖ 10.5 AIC · ⊞ 6.3K

[Copilot]

Pull request overview

Adds safe parallel execution to the remaining eligible addAllowedToNetwork subtest.

Changes:

• Calls t.Parallel() in the comment-line network-block subtest.

Show a summary per file

File	Description
pkg/cli/codemod_mcp_network_addallowed_test.go	Parallelizes an isolated subtest.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

Skills-Based Review 🧠

Applied /tdd — approved, no issues found.

This is a single-line addition of t.Parallel() to a subtest confirmed safe: the subtest operates only on local slices/strings via a pure function with no shared state. The PR body documents race-detector validation (go test -race), which is exactly the right evidence for this type of change.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet46 · 15.5 AIC · ⌖ 10.3 AIC · ⊞ 7.7K
_{Comment /matt to run again}