Validate Playwright mode expressions

[Copilot]

tools.playwright.mode controls compiler-generated runtime setup and must be static. GitHub Actions expressions are now rejected for this field.

• Validation

  • Reject ${{ ... }} values in tools.playwright.mode
  • Return a field-specific error directing authors to mcp or cli

• Coverage

  • Add regression coverage for expression-valued modes

tools:
  playwright:
    mode: ${{ inputs.playwright-mode }} # rejected

[pelikhan]

@copilot update main json schema

[Copilot]

🟡 Changes recommended

Existing schema validation preempts the intended field-specific error in real compiler paths.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds static validation for Playwright mode expressions.

Changes:

• Rejects expression-valued Playwright modes.
• Adds regression coverage for the validator.

File summaries

File	Description
pkg/workflow/playwright_validation.go	Adds mode expression validation.
pkg/workflow/playwright_validation_test.go	Tests expression rejection.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Balanced

[Copilot]

@copilot update main json schema

Updated pkg/parser/schemas/main_workflow_schema.json in 9b3c1e0 (see commit) — tools.playwright.mode now uses oneOf with the cli/mcp enum alongside an expression pattern branch, so ${{ ... }} values pass schema validation and are caught by validatePlaywrightMode's field-specific error instead of the generic schema error. Added TestCompileWorkflowRejectsPlaywrightModeExpression to prove this end-to-end via a full CompileWorkflow call.

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.10