[test-parallel] test: add t.Parallel() to TestCompileWorkflowWithActionRef - #56962
Conversation
Verified safe: uses only t.TempDir()-based paths and a fake git repo via initTestGitRepo, no process-wide state (env vars, cwd changes, or shared globals). Ran go test -race for the package and it passed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ PR Code Quality Reviewer completed the code quality review. Reviewed PR #56962 and found no actionable issues in the single added t.Parallel() change; no GitHub write beyond completion signaling needed.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. No ADR enforcement needed: PR does not have the 'implementation' label and has <=100 new lines of code in business logic directories.
|
|
Lean already. Ship. Warning Firewall blocked 4 domainsThe following domains were blocked by the firewall during workflow execution:
[!TIP] tools:
github:
mode: gh-proxySee GitHub Tools for more information on To allow these domains, add them to the network:
allowed:
- defaults
- "ab.chatgpt.com"
- "api.github.com"
- "chatgpt.com"
- "github.com"See Network Configuration for more information.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /tdd — no issues found; approving.
The single-line addition of t.Parallel() is correct and safe:
t.TempDir()is used for all filesystem state, which is parallel-safe.- All variables are local to the test function.
- No shared global state or sequential ordering constraints are visible.
✅ Clean, safe parallelisation.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet46 · 17.9 AIC · ⌖ 10.3 AIC · ⊞ 7.6K
Comment /matt to run again
There was a problem hiding this comment.
The change correctly adds t.Parallel() to TestCompileWorkflowWithActionRef. The test uses t.TempDir() for isolation, making it safe for parallel execution. No issues found.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · copilot · sonnet46 · 13.4 AIC · ⌖ 10.5 AIC · ⊞ 6.2K
There was a problem hiding this comment.
🟢 Approval recommended
The isolated test uses temporary paths and introduces no shared mutable state.
Pull request overview
Adds parallel execution to a safely isolated compiler test.
Changes:
- Calls
t.Parallel()inTestCompileWorkflowWithActionRef.
File summaries
| File | Description |
|---|---|
pkg/cli/add_command_test.go |
Parallelizes the action-reference compilation test. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
🎉 This pull request is included in a new release. Release: |
Summary
Daily Go test parallelizer run. Analyzed a batch of 25
*_test.gofiles (round-robin, starting afterpkg/cli/gateway_logs_timeline_rpcentry_test.go) via theparallel-safety-batch-checkersub-agent for safet.Parallel()additions.Batch analyzed:
actions/setup/sh/validate_multi_secret_test.gocmd/gh-aw-wasm/compile_recovery_test.gocmd/gh-aw/argument_syntax_test.gocmd/gh-aw/capitalization_test.gocmd/gh-aw/command_groups_test.gocmd/gh-aw/compile_flags_test.gocmd/gh-aw/format_list_test.gocmd/gh-aw/help_examples_test.gocmd/gh-aw/help_flag_test.gocmd/gh-aw/help_sections_order_test.gocmd/gh-aw/main_entry_test.gocmd/gh-aw/main_help_text_test.gocmd/gh-aw/short_description_test.gocmd/gh-aw/version_test.gopkg/actionpins/actionpins_internal_test.gopkg/actionpins/spec_test.gopkg/agentdrain/anomaly_test.gopkg/agentdrain/miner_test.gopkg/agentdrain/spec_test.gopkg/cli/access_log_test.gopkg/cli/actionlint_test.gopkg/cli/actions_build_command_test.gopkg/cli/actions_test.gopkg/cli/add_command_resources_test.gopkg/cli/add_command_test.goMost flagged-safe files already had
t.Parallel()on all top-level tests and eligible subtests, so no change was needed there. One file had a top-level test still missingt.Parallel():Change
pkg/cli/add_command_test.go: addedt.Parallel()toTestCompileWorkflowWithActionRef.Safety rationale:
t.TempDir()-scoped paths and a synthetic git repo (initTestGitRepo), no shared/fixed filesystem paths.t.Setenv/os.Setenv, does not callos.Chdir, and does not touch package-level mutable globals.Files flagged unsafe (and left unchanged) mostly rely on shared/global cobra command state (
rootCmdtraversal/mutation),os.Chdir,t.Setenv/os.Setenv, or package-level globals — these are correctly excluded per the parallelization safety rules.Validation
go test -race ./pkg/cli/... -run TestCompileWorkflowWithActionRef -v→ PASSgo test ./pkg/cli/... -run '<add_command related tests>'→ PASSgo test ./pkg/cli/...run has one pre-existing, unrelated failure (TestInstallCopilotCLIScriptRootlessModeUsesRealScriptWithToolcacheAndNoSudo) caused by lack of outbound network access in this sandbox (curl 403 downloading release checksums), unrelated to this change.t.Parallel()addition.State persistence
state.jsonin cache-memory updated to{"last_file":"pkg/cli/add_command_test.go"}so the next daily run continues round-robin from this point.Warning
Firewall blocked 3 domains
The following domains were blocked by the firewall during workflow execution:
api.github.comgithub.comraw.githubusercontent.com[!TIP]
api.github.comis blocked because GitHub API access uses the built-in GitHub tools by default. Instead of addingapi.github.comtonetwork.allowed, usetools.github.mode: gh-proxyfor direct pre-authenticated GitHub CLI access without requiring network access toapi.github.com:See GitHub Tools for more information on
gh-proxymode.To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.