Skip to content

Prevent PureLock Go cache restore collisions - #57948

Merged
pelikhan merged 4 commits into
mainfrom
copilot/aw-fix-purelock-incomplete-result
Sep 2, 2026
Merged

Prevent PureLock Go cache restore collisions#57948
pelikhan merged 4 commits into
mainfrom
copilot/aw-fix-purelock-incomplete-result

Conversation

Copilot AI commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

PureLock failed before agent execution when setup-go attempted to extract a dependency cache over files already mounted by the cloud-hypervisor sandbox.

  • Agent setup: Disable Go dependency-cache restoration only in the sandboxed agent job; retain caching for precomputation.
  • Workflow artifact: Regenerate purelock.lock.yml from the updated workflow source.
- name: Setup Go
  uses: actions/setup-go@v7.0.0
  with:
    go-version-file: go.mod
    cache: false

Copilot AI linked an issue Sep 2, 2026 that may be closed by this pull request
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix incomplete result issue in PureLock Prevent PureLock Go cache restore collisions Sep 2, 2026
Copilot AI requested a review from pelikhan September 2, 2026 13:25
@pelikhan pelikhan added the awf label Sep 2, 2026
@pelikhan
pelikhan marked this pull request as ready for review September 2, 2026 13:34
Copilot AI balanced review requested due to automatic review settings September 2, 2026 13:35
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

PR Code Quality Reviewer completed the code quality review.

No review comments were posted because this PR change is narrowly scoped and does not introduce a clear blocking issue in the changed lines.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped.

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer was cancelled during the skills-based review.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories.

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

⚠️ Security scanning failed for Ponytail Reviewer. Review the logs for details.

Lean already. Ship.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by Ponytail Reviewer for #57948

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The targeted change matches the observed cache-extraction failure without weakening security controls.

Pull request overview

Prevents PureLock’s sandboxed agent job from restoring a Go cache over mounted files while retaining precomputation caching.

Changes:

  • Disables setup-go caching only for the agent job.
  • Regenerates the compiled workflow artifact.
File summaries
File Description
.github/workflows/purelock.md Disables conflicting agent cache restoration.
.github/workflows/purelock.lock.yml Reflects the source workflow change.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Comment Memory

reviewed_at: 2026-09-02T13:38:27.957+00:00
review_event: COMMENT
top_themes:
  - overly broad workflow comment risks cargo-culting cache disablement
files_reviewed:
  - .github/workflows/purelock.lock.yml
  - .github/workflows/purelock.md
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 18.4 AIC · ⌖ 8.62 AIC · ⊞ 21.8K ·
Comment /review to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking issues

This change looks narrowly scoped, but the comment explaining why cache: false is required is too broad: it attributes the failure to the sandbox mounting the runner's Go module cache, which only justifies disabling restore for this specific sandboxed agent path. If that explanation is wrong or later cargo-culted into other workflows, we'll silently throw away useful dependency caching in places that don't have this collision.

The workflow fix itself is probably fine, but the rationale needs to stay precise.

The diff only changes the post-precompute setup-go step in purelock, and that step runs under a very particular sandbox/runtime configuration. The new comment currently reads like a general setup-go rule rather than a PureLock-agent-specific constraint. That is maintainability debt in a workflow repo where people routinely copy/paste setup blocks.

Tighten the comment so it names the exact failing environment and why restore is unsafe there, for example that the cloud-hypervisor sandbox already exposes a populated module cache into the job filesystem, so setup-go's restore/extract phase collides with existing paths in this one job.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 18.4 AIC · ⌖ 8.62 AIC · ⊞ 21.8K
Comment /review to run again

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Please resolve the merge conflicts on this branch by running make merge-main, then inspect the current PR state and run the pr-finisher skill before handing back to maintainers.

  • Merge conflicts are currently blocking this PR.
  • After the branch is conflict-free, please verify whether anything remains beyond maintainer review/CI follow-up.
  • Current compact context shows no failed checks to prioritize beyond unblocking the branch.

Generated by 👨🍳 PR Sous Chef
Comment /souschef to run again

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 29.3 AIC · ⌖ 8.78 AIC · ⊞ 8.7K ·
Comment /souschef to run again

Copilot AI and others added 2 commits September 2, 2026 17:42
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Please resolve the merge conflicts on this branch by running make merge-main, then inspect the current PR state and run the pr-finisher skill before handing back to maintainers.

  • Merge ...

Resolved the merge conflict with make merge-main, regenerated the workflow lockfile, and pushed merge commit c156748. Local formatting, lint, unit, full test, and recompile validation pass; remaining CI validation requires a maintainer re-trigger.

@pelikhan
pelikhan merged commit 74cfd7d into main Sep 2, 2026
@pelikhan
pelikhan deleted the copilot/aw-fix-purelock-incomplete-result branch September 2, 2026 18:13
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.88.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] PureLock reported incomplete result

4 participants