[safe-output-integrator] test: add fixtures and Go test coverage for ADO/Linear/Jira safe outputs - #58009
Merged
Conversation
Add pkg/cli/workflows/test-copilot-*.md fixtures and compiler_safe_outputs_config_test.go cases for the 13 previously uncovered safe-output types: - ado-create-work-item, ado-update-work-item, ado-comment-on-work-item, ado-assign-work-item, ado-link-work-items, ado-upload-workitem-attachment - linear-create-issue, linear-add-comment, linear-update-issue - jira-create-issue, jira-update-issue, jira-add-comment, jira-add-label Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
deleted the
integrate-safe-outputs-coverage-68cf048bff25bcf0
branch
September 2, 2026 19:12
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closed the gap between
SafeOutputsConfigand its test/fixture coverage. Found 13 safe-output types with zero coverage in bothpkg/cli/workflows/*.mdfixtures andpkg/workflow/compiler_safe_outputs_config_test.go(TestAddHandlerManagerConfigEnvVar): all Azure DevOps work-item outputs, all Linear outputs, and all Jira outputs.Key changes
pkg/cli/workflows/test-copilot-<type>.md, each with minimalworkflow_dispatchfrontmatter,engine: copilot, the relevantsafe-outputs.<type>block (plus requiredenv/linear-tokencredentials matching documented patterns), and a short task instructing use of the corresponding tool.compiler_safe_outputs_config_test.go, following the existing style (BaseSafeOutputConfig.Max,expectedKeysin underscore form), covering:ado_create_work_item,ado_update_work_item,ado_comment_on_work_item,ado_assign_work_item,ado_link_work_items,ado_upload_workitem_attachmentlinear_create_issue,linear_add_comment,linear_update_issuejira_create_issue,jira_update_issue,jira_add_comment,jira_add_labelCoverage analysis details
SafeOutputsConfigstruct (pkg/workflow/safe_outputs_config_types.go), excluding config-only keys (jobs,github-app,env,github-token,allowed-domains,allowed-github-references,staged,threat-detection).pkg/workflow/safe_output_handlers.gofor handler keys/tool names,safe_outputs_azure_devops.go/linear_safe_outputs.go/jira.gofor config struct shapes, andsafe_outputs_validation_config.goforDefaultMaxvalues (all 1, exceptado_link_work_items= 5).Verification note
storage.googleapis.com(used for Go module proxy zip downloads), sogo build/go testcould not be run end-to-end here. I validated instead via:gofmt -lon the edited test file (clean, no issues).CreateWorkItemConfig,LinearCreateIssueConfig,JiraSafeOutputConfig, etc.) and existing table-test entries for the same style.docs/src/content/docs/reference/safe-outputs.md.Please run
go test ./pkg/workflow/... -run TestAddHandlerManagerConfigEnvVarandgh aw compileover the new fixtures in CI to confirm.Next actions
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
storage.googleapis.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.