Restore MicroVM and ARC runner cards on homepage - #58054
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
|
Cloud hypervisor? |
|
@copilot update the page to specifically mention the supported sandboxes, e.g., cloud-hypervisor, gvisor, and docker-sbx, just as the page lists supported agents |
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Updated the homepage to list standard Docker, |
There was a problem hiding this comment.
🟢 Approval recommended
The changes satisfy the linked issue’s acceptance criteria and use valid documentation targets.
Pull request overview
Restores homepage visibility for MicroVM isolation and self-hosted/ARC runner support.
Changes:
- Restores the requested MicroVM and ARC runner cards.
- Removes the Guardrails Mermaid diagram.
- Adds a sandbox runtime summary.
File summaries
| File | Description |
|---|---|
docs/src/content/docs/index.mdx |
Updates homepage cards, copy, and diagram. |
.github/workflows/docs-noob-tester.lock.yml |
Refreshes generated body-hash metadata. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
Lean already. Ship. The PR is a small docs-only change with no obvious over-engineering to cut. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
|
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. Test Quality Sentinel skipped.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
There was a problem hiding this comment.
Skills-Based Review 🧠
This is a small, well-scoped documentation change (homepage content restore) with a corresponding, expected lock-file regeneration. Verified both new links (/gh-aw/reference/self-hosted-runners/ and /gh-aw/reference/glossary/#docker-sbx) resolve to existing content. No code logic, tests, or architecture changes are involved, so /tdd, /diagnosing-bugs, and /codebase-design do not surface actionable findings here — content-only PRs like this are out of scope for those skills.
Nothing blocking. Approving.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · 16.6 AIC · ⌖ 14.5 AIC · ⊞ 10.3K
Comment /matt to run again
There was a problem hiding this comment.
Reviewed with Impeccable critique/audit modes (docs-only content restore: new/re-added FeatureCards, updated intro copy, removed mermaid diagram, updated docs-noob-tester lock metadata). No blocking issues found. Left one minor, non-blocking icon-reuse suggestion inline.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · copilot · sonnet50 · 24.7 AIC · ⌖ 13.3 AIC · ⊞ 8.3K
| </FeatureCard> | ||
| <FeatureCard icon="mark-github" title="GitHub Integration" href="/gh-aw/reference/github-tools/"> | ||
| Deep integration with Actions, Issues, PRs, Discussions, and repository management | ||
| <FeatureCard icon="server" title="Self-Hosted & ARC Runners" href="/gh-aw/reference/self-hosted-runners/"> |
There was a problem hiding this comment.
Minor: this new Self-Hosted & ARC Runners card reuses icon="server", the same icon already used two cards later for Use at Scale in Organizations (line 55). Since both live in the same 3-column grid, the repeated icon reduces visual distinctiveness/scanability across the row. Consider a more specific octicon (e.g. cpu, rocket, or terminal) for one of the two cards.
@copilot please address this.
Comment MemoryNote This comment is managed by comment memory.It stores persistent context for this thread in the code block at the top of this comment.
|
There was a problem hiding this comment.
Verdict
No blocking issues in the changed lines.
Why this stays non-blocking
The new homepage copy is consistent with existing reference docs: cloud-hypervisor is already documented as preview-only, docker-sbx already points at the glossary entry used here, and the self-hosted runners page already documents the Linux and ARC/DinD constraints that this card links to.
🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 31.2 AIC · ⌖ 7.31 AIC · ⊞ 21.8K
Comment /review to run again
|
🎉 This pull request is included in a new release. Release: |
Restore prominent homepage coverage for MicroVM isolation and self-hosted/ARC runner support.