Fix Weekly Editors Health Check safe outputs and editor discovery - #58765
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix workflow failure in Weekly Editors Health Check
Fix Weekly Editors Health Check safe outputs and editor discovery
Sep 5, 2026
pelikhan
marked this pull request as ready for review
September 5, 2026 09:01
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A critical failure-handling issue and two moderate discovery/reporting issues remain unresolved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Improves editor discovery and safe no-action handling in the weekly editors health check.
Changes:
- Broadens supported editor-link formats.
- Adds explicit
noopguidance and configuration. - Regenerates the compiled workflow.
Required changes:
- Moderate (1 vote): Preserve quiet no-op reporting rather than enabling managed issue reports.
- Moderate (2 votes): Restrict discovery to standalone, non-image links with one URL per editor and explicit precedence.
- Critical (1 vote): Do not classify tool failures or unreachable targets as successful no-ops; report incomplete checks.
File summaries
| File | Description |
|---|---|
.github/workflows/weekly-editors-health-check.md |
Updates discovery and no-op behavior; contains unresolved issues above. |
.github/workflows/weekly-editors-health-check.lock.yml |
Regenerates the compiled workflow configuration. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| - If a screenshot cannot be taken (Playwright error), log the error and continue with the remaining editors. | ||
| - If no screenshots were successfully taken and no documentation changes are needed, do **not** open a pull request. Instead, exit successfully after logging the results. | ||
| - Always attempt all editors before deciding whether to create a PR. | ||
| - If no screenshots were successfully taken or no documentation changes are needed (e.g., all screenshots and links are unchanged and already up to date), do **not** open a pull request. Instead, call the `noop` safe output tool explaining what was checked and why no PR was needed. |
| labels: [documentation, automation] | ||
| reviewers: [copilot] | ||
| expires: 7d | ||
| noop: |
| 1. Track the most recent `###` heading encountered — this is the editor name for all `<LinkButton>` elements that follow it until the next heading. | ||
| 2. For each `<LinkButton href="...">` element found, record the `href` value as the editor URL. | ||
| 1. Track the most recent `###` heading encountered — this is the editor name. | ||
| 2. For each editor section (under a `###` heading), extract the editor URL from `<LinkButton href="...">`, markdown links (`[...](...)`), or plain URL bullet items (`- https://...` or `https://...`). |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Weekly Editors Health Check workflow failed safe-output validation because the agent discovered zero editors due to a strict syntax expectation in the prompt and completed without emitting a safe output or calling
noop.Changes Made
Workflow Configuration (
.github/workflows/weekly-editors-health-check.md):noop:insafe-outputsand importedshared/noop-reminder.md.<LinkButton>, markdown links ([text](url)), and plain bullet URLs (- https://...) under###headings.nooptool with run diagnostics whenever no PR is required (e.g. previews already up-to-date or all targets unreachable).Compiled Workflows:
.github/workflows/weekly-editors-health-check.lock.ymlto include thenooptool handler, reminder prompt injections, and environment variable bindings.