Route Daily Go Test Parallelizer GitHub operations through MCP proxy - #58863
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Category: bug | Risk: medium | Score: 49 | Action: batch_review | Batch: workflow-reliability. Warning Firewall blocked 2 domainsThe following domains were blocked by the firewall during workflow execution:
[!TIP] tools:
github:
mode: gh-proxySee GitHub Tools for more information on To allow these domains, add them to the network:
allowed:
- defaults
- "api.github.com"
- "github.com"See Network Configuration for more information.
|
|
Lean already. Ship. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. Test Quality Sentinel skipped.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. No ADR enforcement needed: PR does not have the implementation label and has ≤100 new lines of code in business logic directories.
|
Comment MemoryNote This comment is managed by comment memory.It stores persistent context for this thread in the code block at the top of this comment.
|
There was a problem hiding this comment.
Verdict
Non-blocking change. The workflow now switches GitHub operations onto the CLI proxy path, and I didn't find a changed-line regression that obviously breaks execution.
What I checked
- The workflow source enables
cli-proxyandgithub.mode: gh-proxy, which matches the established pattern used by other proxied workflows in this repo. - The generated lockfile adds the CLI proxy lifecycle (
Start CLI Proxy/Stop CLI Proxy), injects the safeoutputs CLI prompt, and passes the DIFC proxy host/cert into the AWF invocation. - The removed in-container GitHub MCP server wiring is intentional here rather than an accidental capability drop: the workflow prompt already expects GitHub reads through the pre-authenticated
ghCLI path.
🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 32 AIC · ⌖ 7.33 AIC · ⊞ 21.8K
Comment /review to run again
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed proxy configuration and generated workflow changes have no unresolved issues.
Pull request overview
Routes the Daily Go Test Parallelizer’s GitHub operations through the authenticated CLI proxy to avoid firewall-blocked direct API traffic.
Changes:
- Enables
cli-proxyand sets GitHub togh-proxymode. - Regenerates the compiled workflow with proxy routing and cleanup.
File summaries
| File | Description |
|---|---|
.github/workflows/daily-go-test-parallelizer.md |
Configures proxied GitHub access. |
.github/workflows/daily-go-test-parallelizer.lock.yml |
Applies the generated proxy topology. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design (fallback heuristic used for skill selection since pr-triage returned only prose analysis, not the documented JSON shape).
This is a minimal, config-only change that routes the daily-go-test-parallelizer workflow's GitHub reads through the existing cli-proxy/github: mode: gh-proxy pattern, consistent with dozens of other workflows in this repo (ci-doctor.md, copilot-opt.md, contribution-check.md, etc.).
📋 Verification notes
tools.cli-proxy: true+tools.github.mode: gh-proxyis an established, well-tested configuration path (pkg/workflow/github_mode_gh_proxy_integration_test.go,compiler_difc_proxy.go), not a novel abstraction — low architectural risk.- The regenerated
.lock.ymlcorrectly reflects the source: removes the directgithubMCP server container/guard env vars, adds theStart CLI Proxy/Stop CLI Proxysteps, updates the firewall topology (awmg-mcpg→awmg-mcpg,awmg-cli-proxy), and threads--difc-proxy-host/--difc-proxy-ca-certinto theawfinvocation. - No
toolsetskey is set ongithub:, so it falls back to the implicitdefaulttoolset (context,repos,issues,pull_requests), which matches the previous MCP server'sGITHUB_TOOLSETSvalue and the workflow's existingissues: read/pull-requests: readpermissions — behavior-preserving. - No new abstractions, tests, or bug fixes are involved — the diff is a targeted frontmatter addition plus its compiled artifact, matching the pattern used elsewhere in the repo.
No actionable issues found. Approving.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · 59.3 AIC · ⌖ 14.7 AIC · ⊞ 10.3K
Comment /matt to run again
The workflow was generating direct GitHub API traffic, contributing to widespread firewall blocks and unreliable runs. GitHub operations now use the intended proxy path.
cli-proxy.mode: gh-proxy..lock.ymlto apply the proxy topology.