Phase 3: GitHub API client + all shared commands (Go port)#1533
Draft
offbyone wants to merge 1 commit intoo1/golang-port/2from
Draft
Phase 3: GitHub API client + all shared commands (Go port)#1533offbyone wants to merge 1 commit intoo1/golang-port/2from
offbyone wants to merge 1 commit intoo1/golang-port/2from
Conversation
This was referenced Mar 31, 2026
offbyone
force-pushed
the
o1/golang-port/3
branch
from
cddb7a6 to
1da1059
Compare
offbyone
force-pushed
the
o1/golang-port/2
branch
from
916309f to
6ec826e
Compare
This was referenced Mar 31, 2026
This PR implements the core GitHub API client and all shared gei subcommands in Go, building on the project skeleton (PR 1) and HTTP/auth foundation (PR 2). ## GitHub API client (pkg/github/) - Custom GraphQL client with pagination, secondary rate limit detection and retry, and navigateJSON() dot-path traversal - 32+ migration API methods via google/go-github REST client: organization, repository, team, mannequin, migration lifecycle - Comprehensive models (models.go) for all API response types ## Shared command infrastructure (internal/cmdutil/) - UserError type for user-friendly error messages - Flag validators: ValidatePaired, ValidateAtLeastOne, ValidateExactlyOne - Migration status constants and classifier (pkg/migration/) ## Commands (cmd/gei/) - wait-for-migration: poll migration status with configurable interval - abort-migration: cancel in-progress migrations - download-logs: fetch and save migration log archives - grant-migrator-role / revoke-migrator-role: manage migration permissions - create-team: create GitHub teams with idempotent slug handling - generate-mannequin-csv: export mannequin data to CSV - reclaim-mannequin: reclaim mannequins from CSV or individual args ## Supporting packages - pkg/download/: migration log download service with temp file cleanup - pkg/mannequin/: mannequin reclamation service with CSV parsing - pkg/version/: version checker against GitHub releases - pkg/status/: GitHub status page availability check ## Testing - 170+ tests across all packages, all passing with -race - External test package convention (package foo_test) - httptest-based test servers for API client tests ## Tooling - golangci-lint v2 configured, 0 issues - Go 1.25.4 added to mise.toml alongside dotnet 8.0.410 - Go binary names added to .gitignore
offbyone
force-pushed
the
o1/golang-port/2
branch
from
6ec826e to
e070b3e
Compare
offbyone
force-pushed
the
o1/golang-port/3
branch
from
1da1059 to
470dc87
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the core GitHub API client and all shared
geisubcommands.Custom GraphQL client with pagination and secondary rate limit detection/retry
32+ migration API methods via
google/go-githubREST clientUserErrortype, flag validators, migration status constants ininternal/cmdutil/Shared commands: wait-for-migration, abort-migration, download-logs, grant/revoke-migrator-role, create-team, generate-mannequin-csv, reclaim-mannequin
Supporting packages:
pkg/download/,pkg/mannequin/,pkg/version/,pkg/status/170+ tests across all packages, all passing with
-racegolangci-lint v2 configured, 0 issues
Did you write/update appropriate tests
Release notes updated (if appropriate)— not user-facing yet (parallel Go port)Appropriate logging output
Issue linked— tracking via PR stackDocs updated (or issue created)
New package licenses are added to
ThirdPartyNotices.txt(if applicable)PR Stack (Go port)