Phase 6: ADO API client + all ado2gh commands (Go port)#1537
Draft
offbyone wants to merge 4 commits intoo1/golang-port/5from
Draft
Phase 6: ADO API client + all ado2gh commands (Go port)#1537offbyone wants to merge 4 commits intoo1/golang-port/5from
offbyone wants to merge 4 commits intoo1/golang-port/5from
Conversation
This was referenced Apr 1, 2026
ADO Client (pkg/ado/client.go): - Complete ADO REST API client with ~35 methods covering orgs, team projects, repos, pipelines, service connections, identity, and permissions - Three pagination patterns: continuation-token, top/skip, binary-search count - Cooperative Retry-After throttle with exponential backoff - PAT-based auth (base64-encoded), configurable base URL for ADO Server - 1559 lines implementation, 1431 lines tests, 74 lines models ado2gh migrate-repo (cmd/ado2gh/migrate_repo.go): - Full port of C# MigrateRepoCommandHandler with identical flag set - Token validation, org existence checks, permission verification - Queue-only mode support, wait-for-migration integration - Consumer-defined interfaces, two-constructor pattern (test/live) - 369 lines implementation, 414 lines tests (9 tests) Also: - Wired all remaining gei commands with live constructors (cmd/gei/wiring.go) - Fixed permissions error message quoting (backticks) in gei + ado2gh - Added gh-gei/, gh-ado2gh/, gh-bbs2gh/ to .gitignore
…t command - Port AdoInspectorService to pkg/ado/inspector.go with caching, org/project/repo/pipeline discovery, PR counts, CSV loading, and ReplaceInvalidCharactersWithDash - Port ado2gh generate-script command with all 17 flags, sequential and parallel script generation modes - Three-level iteration (orgs → team projects → repos) with conditional team creation, service connection sharing, pipeline rewiring - Two-phase parallel script: queue phase with ExecAndGetMigrationID + wait/post-migration phase with ExecBatch - Add ExecBatchFunctionBlock and ValidateADOEnvVars to pkg/scriptgen/templates.go - Wire generate-script into cmd/ado2gh/main.go - 20+ inspector tests, 28 generate-script tests, all passing - 0 lint issues in ado packages
…raction Port all 8 ado2gh simple commands (Tasks 23a-f): - lock-ado-repo, disable-ado-repo - add-team-to-repo, configure-autolink - share-service-connection, integrate-boards - rewire-pipeline (with PipelineTriggerService ~557 lines) - test-pipelines (with PipelineTestService ~274 lines) Extract shared commands into internal/sharedcmd/ (Task 23g): - Created 8 files in internal/sharedcmd/ with exported interfaces, Run*, Validate*, types, and constants for all commands shared between gei and ado2gh (wait-for-migration, abort-migration, download-logs, grant/revoke-migrator-role, create-team, generate-mannequin-csv, reclaim-mannequin) - Updated cmd/gei/ files to be thin wrappers calling sharedcmd.* - Created cmd/ado2gh/wiring.go with 8 Live constructors - Wired all 18 commands into cmd/ado2gh/main.go Lint fixes (Task 23h): - Renamed AdoBranchPolicy* types to BranchPolicy* (revive stutter) - Extracted "unknown" constant (goconst) - Tagged switch and TrimPrefix (staticcheck) - File permissions 0o600 (gosec) - Removed dead code from cmd/gei/ after sharedcmd extraction - Fixed misspelling in test comment
…ators Add inventory-report command for ado2gh that generates CSV reports for ADO orgs, team projects, repos, and pipelines. Includes: - pkg/ado/csvgen.go: 4 CSV generator functions (orgs, team projects, repos, pipelines) with thousand-separator formatting, C#-compatible date/boolean formatting, and minimal mode support - pkg/ado/csvgen_test.go: 15+ tests covering all generators and edge cases - cmd/ado2gh/inventory_report.go: Command handler with proper flag validation, inspector setup, and sequential CSV generation - cmd/ado2gh/inventory_report_test.go: 3+ handler tests - pkg/ado/inspector.go: Added SetOrgFilter/GetOrgFilter methods for single-org inventory scoping - Wired into cmd/ado2gh/main.go All ADO-specific commands now complete (11 + 8 shared = 19 total).
offbyone
force-pushed
the
o1/golang-port/6
branch
from
bb4e900 to
ccd68f9
Compare
offbyone
force-pushed
the
o1/golang-port/5
branch
from
5ee2b0f to
c185e00
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete port of all ado2gh functionality from C# to Go. The
ado2ghbinary now has full feature parity with 19 commands (11 ADO-specific + 8 shared).ADO REST API client (
pkg/ado/) with ~35 methods covering orgs, team projects, repos, pipelines, service connections, identity, and permissionsThree pagination patterns: continuation-token, top/skip, binary-search count
Cooperative Retry-After throttle with exponential backoff, PAT-based auth
AdoInspectorService with caching, org/project/repo/pipeline discovery, PR counts, CSV loading
Commands: migrate-repo, generate-script, inventory-report, plus 8 simpler commands (lock-ado-repo, disable-ado-repo, add-team-to-repo, configure-autolink, share-service-connection, integrate-boards, rewire-pipeline, test-pipelines)
Extracted 8 shared commands into
internal/sharedcmd/for reuse between gei, ado2gh, and bbs2ghAll tests passing, 0 lint issues
Did you write/update appropriate tests
Release notes updated (if appropriate)— not user-facing yet (parallel Go port)Appropriate logging output
Issue linked— tracking via PR stackDocs updated (or issue created)— internal packages, covered by godocNew package licenses are added to— no new depsThirdPartyNotices.txt(if applicable)PR Stack (Go port)