Add --lock-source-repo option.#589
Merged
dylan-smith merged 13 commits intogithub:mainfrom Aug 24, 2022
Merged
Conversation
Get the unit tests all working.
5 tasks
dylan-smith
added a commit
that referenced
this pull request
Aug 23, 2022
<!-- For the checkboxes below you must check each one to indicate that you either did the relevant task, or considered it and decided there was nothing that needed doing --> In `gei migrate-repo` the function `LogAndValidateOptions()` had gotten so large that `dotnet format` was starting to complain if you added anything new to it. Like in this other PR: #589 I refactored it into separate `LogOptions()` and `ValidateOptions()` functions, which I think is better even if our linter didn't complain. This is pre-req work for the lock-repo PR and issue #385 - [x] Did you write/update appropriate tests - [x] Release notes updated (if appropriate) - [x] Appropriate logging output - [x] Issue linked - [x] Docs updated (or issue created) <!-- For docs we should review the docs at: https://docs.github.com/en/early-access/github/migrating-with-github-enterprise-importer and the README.md in this repo If a doc update is required based on the changes in this PR, it is sufficient to create an issue and link to it here. The doc update can be made later/separately. The process to update the docs can be found here: https://github.com/github/docs-early-access#opening-prs The markdown files are here: https://github.com/github/docs-early-access/tree/main/content/github/migrating-with-github-enterprise-importer -->
dylan-smith
approved these changes
Aug 24, 2022
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses #385 by adding the cli option
--lock-source-repo.For GHES source, this uses the
lock_repositoriesoption as documented here.For GHEC source, this uses the new lockSource option in the GraphAPI mentioned here.
--lock-source-repooption #597