Skip to content

refactor LogAndValidateOptions#595

Merged
dylan-smith merged 1 commit intomainfrom
dylan-smith/refactor-logandvalidateoptions
Aug 23, 2022
Merged

refactor LogAndValidateOptions#595
dylan-smith merged 1 commit intomainfrom
dylan-smith/refactor-logandvalidateoptions

Conversation

@dylan-smith
Copy link
Copy Markdown
Contributor

@dylan-smith dylan-smith commented Aug 23, 2022

In gei migrate-repo the function LogAndValidateOptions() had gotten so large that dotnet format was starting to complain if you added anything new to it. Like in this other PR: #589

I refactored it into separate LogOptions() and ValidateOptions() functions, which I think is better even if our linter didn't complain.

This is pre-req work for the lock-repo PR and issue #385

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)

@dylan-smith dylan-smith marked this pull request as ready for review August 23, 2022 23:39
@dylan-smith dylan-smith enabled auto-merge (squash) August 23, 2022 23:43
@dylan-smith dylan-smith merged commit 4fb99ee into main Aug 23, 2022
@dylan-smith dylan-smith deleted the dylan-smith/refactor-logandvalidateoptions branch August 23, 2022 23:50
@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 86% 86% 349
ado2gh 88% 84% 498
bbs2gh 44% 24% 51
Octoshift 92% 78% 696
Summary 88% (4452 / 5068) 80% (953 / 1184) 1594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants