fast forward active branches where local is behind remote#40
Open
skarim wants to merge 1 commit intoskarim/fix-view-difffrom
Open
fast forward active branches where local is behind remote#40skarim wants to merge 1 commit intoskarim/fix-view-difffrom
skarim wants to merge 1 commit intoskarim/fix-view-difffrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for fast-forwarding stack branches that are locally behind their remote counterpart, so sync/rebase operate on up-to-date branch tips before cascading rebases.
Changes:
- Introduce a shared
fastForwardBrancheshelper to fast-forward active stack branches when local is strictly behindremote/<branch>. - Run branch fast-forwarding during
gh stack sync(and trigger cascade rebase when any branch moved) and duringgh stack rebase. - Update sync/rebase tests and mocks to model
origin/<branch>SHAs and cover branch fast-forward scenarios.
Show a summary per file
| File | Description |
|---|---|
| cmd/utils.go | Adds fastForwardBranches helper used by sync/rebase to fast-forward active branches behind the chosen remote. |
| cmd/sync.go | Calls fastForwardBranches and treats “any branch moved” as a reason to cascade rebase. |
| cmd/rebase.go | Calls fastForwardBranches before the cascade rebase begins. |
| cmd/sync_test.go | Adjusts mock SHA behavior and adds coverage for branch fast-forward-driven rebases/force pushes. |
| cmd/rebase_test.go | Adjusts mock SHA behavior and adds coverage for branch fast-forward behavior during rebase. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast-forward stack branches that are behind their remote
In certain situations, when there was an upstream commit not present on local,
gh stack rebaseandgh stack syncwould rebase on top of the stale local ref, effectively dropping the new commits.Fix: Before the cascade rebase, both
rebaseandsyncnow detect stack branches where the local ref is strictly behind the remote tracking branch and fast-forward them. If the branch has diverged, it's left alone (the push step handles that). Forsync, a branch fast-forward also triggers the cascade rebase even if trunk hasn't moved.