Persist MCP App success views across host remounts - #2971
Open
cipheraxat wants to merge 1 commit into
Open
Conversation
Deferral results now include _meta.viewUUID so pr-write, pr-edit, and issue-write can restore SuccessView from localStorage after the host tears down the iframe (e.g. switching chat sessions). Fixes github#2965.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewToolResultAwaitingFormSubmissionnow carry_meta.viewUUID. The write/edit apps save completed state under a namespaced localStorage key and restore it synchronously on remount so the success screen shows on the first paint (no form flash).Test plan
go test ./pkg/utils/ ./pkg/github/ -count=1(or at least the pullrequests + utils packages)ui/:npm ci && npm run typecheck && npm test && npm run buildviewUUID)