Skip to content

fix: call super.connectedCallback() in button sub-components #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pramishpy wants to merge 1 commit into
base: main
Choose a base branch
from
+50 −0
Open

fix: call super.connectedCallback() in button sub-components #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ class MarkdownButtonElement extends HTMLElement {

class MarkdownHeaderButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
const level = parseInt(this.getAttribute('level') || '3', 10)
this.#setLevelStyle(level)
}
Expand Down Expand Up @@ -178,6 +179,7 @@ if (!window.customElements.get('md-header')) {

class MarkdownBoldButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
styles.set(this, {prefix: '**', suffix: '**', trimFirst: true})
}
}
Expand All @@ -189,6 +191,7 @@ if (!window.customElements.get('md-bold')) {

class MarkdownItalicButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
styles.set(this, {prefix: '_', suffix: '_', trimFirst: true})
}
}
Expand All @@ -200,6 +203,7 @@ if (!window.customElements.get('md-italic')) {

class MarkdownQuoteButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
styles.set(this, {prefix: '> ', multiline: true, surroundWithNewlines: true})
}
}
Expand All @@ -211,6 +215,7 @@ if (!window.customElements.get('md-quote')) {

class MarkdownCodeButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
styles.set(this, {prefix: '`', suffix: '`', blockPrefix: '```', blockSuffix: '```'})
}
}
Expand All @@ -222,6 +227,7 @@ if (!window.customElements.get('md-code')) {

class MarkdownLinkButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
styles.set(this, {prefix: '[', suffix: '](url)', replaceNext: 'url', scanFor: 'https?://'})
}
}
Expand All @@ -233,6 +239,7 @@ if (!window.customElements.get('md-link')) {

class MarkdownImageButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
styles.set(this, {prefix: '![', suffix: '](url)', replaceNext: 'url', scanFor: 'https?://'})
}
}
Expand All @@ -244,6 +251,7 @@ if (!window.customElements.get('md-image')) {

class MarkdownUnorderedListButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
styles.set(this, {prefix: '- ', multiline: true, unorderedList: true})
}
}
Expand All @@ -255,6 +263,7 @@ if (!window.customElements.get('md-unordered-list')) {

class MarkdownOrderedListButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
styles.set(this, {prefix: '1. ', multiline: true, orderedList: true})
}
}
Expand All @@ -266,6 +275,7 @@ if (!window.customElements.get('md-ordered-list')) {

class MarkdownTaskListButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
styles.set(this, {prefix: '- [ ] ', multiline: true, surroundWithNewlines: true})
}
}
Expand All @@ -277,6 +287,7 @@ if (!window.customElements.get('md-task-list')) {

class MarkdownMentionButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
styles.set(this, {prefix: '@', prefixSpace: true})
}
}
Expand All @@ -288,6 +299,7 @@ if (!window.customElements.get('md-mention')) {

class MarkdownRefButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
styles.set(this, {prefix: '#', prefixSpace: true})
}
}
Expand All @@ -299,6 +311,7 @@ if (!window.customElements.get('md-ref')) {

class MarkdownStrikethroughButtonElement extends MarkdownButtonElement {
connectedCallback() {
super.connectedCallback()
styles.set(this, {prefix: '~~', suffix: '~~', trimFirst: true})
}
}
Expand Down
37 changes: 37 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,43 @@ describe('markdown-toolbar-element', function () {
})
})

describe('role attribute', function () {
afterEach(function () {
document.body.innerHTML = ''
})

const buttonTags = [
'md-header',
'md-bold',
'md-italic',
'md-quote',
'md-code',
'md-link',
'md-image',
'md-unordered-list',
'md-ordered-list',
'md-task-list',
'md-mention',
'md-ref',
'md-strikethrough'
]

for (const tag of buttonTags) {
it(`sets role="button" on <${tag}> when connected`, function () {
const el = document.createElement(tag)
document.body.append(el)
assert.equal(el.getAttribute('role'), 'button')
})

it(`preserves custom role on <${tag}> if already present`, function () {
const el = document.createElement(tag)
el.setAttribute('role', 'none')
document.body.append(el)
assert.equal(el.getAttribute('role'), 'none')
})
}
})

describe('in shadow DOM', function () {
it('finds field and inserts markdown', function () {
const div = document.createElement('div')
Expand Down
Loading