This repository was archived by the owner on Oct 13, 2025. It is now read-only.
Sort reviews by ID rather than date so there cannot be a tie. #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwage
approved these changes
May 31, 2024
kodiakhq bot
referenced
this pull request
in weareinreach/TransMascFutures
Aug 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [actions/upload-artifact](https://togithub.com/actions/upload-artifact) | action | digest | `0b2256b` -> `834a144` | [](https://securityscorecards.dev/viewer/?uri=github.com/actions/upload-artifact) | | [chromaui/action](https://togithub.com/chromaui/action) | action | digest | `04320d7` -> `fdbe775` | [](https://securityscorecards.dev/viewer/?uri=github.com/chromaui/action) | | [github/codeql-action](https://togithub.com/github/codeql-action) | action | digest | `afb54ba` -> `eb055d7` | [](https://securityscorecards.dev/viewer/?uri=github.com/github/codeql-action) | | [github/privileged-requester](https://togithub.com/github/privileged-requester) | action | minor | `v2.1.0` -> `v2.2.0` | [](https://securityscorecards.dev/viewer/?uri=github.com/github/privileged-requester) | --- ### Release Notes <details> <summary>github/privileged-requester (github/privileged-requester)</summary> ### [`v2.2.0`](https://togithub.com/github/privileged-requester/releases/tag/v2.2.0) [Compare Source](https://togithub.com/github/privileged-requester/compare/v2.1.0...v2.2.0) #### What's Changed - Sort reviews by ID rather than date so there cannot be a tie. by [@​chrisgavin](https://togithub.com/chrisgavin) in [https://github.com/github/privileged-requester/pull/134](https://togithub.com/github/privileged-requester/pull/134) - Bump actions/upload-artifact from 3.1.3 to 4.3.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/github/privileged-requester/pull/145](https://togithub.com/github/privileged-requester/pull/145) - Bump github/codeql-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/github/privileged-requester/pull/132](https://togithub.com/github/privileged-requester/pull/132) - Bump eslint from 8.54.0 to 8.57.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/github/privileged-requester/pull/148](https://togithub.com/github/privileged-requester/pull/148) - Bump prettier from 3.1.0 to 3.2.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/github/privileged-requester/pull/144](https://togithub.com/github/privileged-requester/pull/144) - Bump undici from 5.28.1 to 5.28.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/github/privileged-requester/pull/150](https://togithub.com/github/privileged-requester/pull/150) - Update all node packages by [@​GrantBirki](https://togithub.com/GrantBirki) in [https://github.com/github/privileged-requester/pull/151](https://togithub.com/github/privileged-requester/pull/151) #### New Contributors - [@​chrisgavin](https://togithub.com/chrisgavin) made their first contribution in [https://github.com/github/privileged-requester/pull/134](https://togithub.com/github/privileged-requester/pull/134) **Full Changelog**: github/privileged-requester@v2.1.0...v2.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday,before 4am on Thursday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/weareinreach/TransMascFutures). PR-URL: #445 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sorts reviews by ID rather than date. The reason for this is that submission date only has a 1 second granularity, so it's possible (and seems reasonably common) for two reviews to be submitted at the same time. The ID on the other hand is a monotonically increasing counter that is guaranteed to be unique for each review. I'm hoping this is sufficient to fix the action sometimes believing it doesn't need to approve a PR that it actually does.