Skip to content

Use SubmitEvent.submitter to ensure value is included with request #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
muan wants to merge 1 commit into from
Closed

Use SubmitEvent.submitter to ensure value is included with request #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,14 @@ function parseHTML(document: Document, html: string): DocumentFragment {
return document.importNode(template.content, true)
}

function serialize(form: HTMLFormElement): string {
function serialize(form: HTMLFormElement, submitter): string {
const params = new URLSearchParams()
for (const [name, value] of formDataEntries(form)) {
params.append(name, value)
const entries = 'entries' in FormData.prototype ? new FormData(form).entries() : formDataEntries(form)
for (const [name, value] of [...entries]) {
params.append(name, value.toString())
}
if (submitter && submitter.name) {
params.append(submitter.name, submitter.value)
}
return params.toString()
}
Expand Down Expand Up @@ -103,7 +107,7 @@ function handleSubmit(event: Event) {
return
}

const req = buildRequest(form)
const req = buildRequest(form, event.submitter)
const [kickerPromise, ultimateResolve, ultimateReject] = makeDeferred()

event.preventDefault()
Expand Down Expand Up @@ -171,7 +175,7 @@ async function processHandlers(
return kickerWasCalled
}

function buildRequest(form: HTMLFormElement): SimpleRequest {
function buildRequest(form: HTMLFormElement, submitter: HTMLInputElement | HTMLButtonElement | null): SimpleRequest {
const req: SimpleRequest = {
method: form.method || 'GET',
url: form.action,
Expand All @@ -180,7 +184,7 @@ function buildRequest(form: HTMLFormElement): SimpleRequest {
}

if (req.method.toUpperCase() === 'GET') {
const data = serialize(form)
const data = serialize(form, submitter)
if (data) {
req.url += (~req.url.indexOf('?') ? '&' : '?') + data
}
Expand Down