This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Clean up specs with some implicit parameters. #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test cases are a good use of `-XImplicitParams`, because often one finds oneself plumbing a bunch of parameters obtained from IO through a dozen layers of pure functions. Implicit parameters make this sort of passing significantly easier. Fixes #128.
added 2 commits
June 12, 2019 13:59
robrix
approved these changes
Jun 12, 2019
|
|
||
| spec :: TaskSession -> Spec | ||
| spec session = parallel $ do | ||
| spec :: (?session :: TaskSession) => Spec |
Contributor
There was a problem hiding this comment.
You could define this as a constraint synonym somewhere and lose the LANGUAGE pragma as well as simplifying the syntax, rather like HasCallStack. (You’d also need a currentSession binding which uses it.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases are a good use of
-XImplicitParams, because often onefinds oneself plumbing a bunch of parameters obtained from IO through
a dozen layers of pure functions. Implicit parameters make this sort
of passing significantly easier.
Fixes #128.