fix: add timeout to prompt step subprocess execution

[Quratulain-bilal]

Summary

The prompt step subprocess.run() had no timeout, allowing a hung LLM invocation to block the entire workflow engine indefinitely. The shell step already defaults to a 300s timeout.

Changes

• src/specify_cli/workflows/steps/prompt/init.py: Added timeout parameter (defaulting to 300s, matching shell step) and handle subprocess.TimeoutExpired gracefully.

Testing

All 176 workflow tests pass.

[mnriem]

Please make sure the default timeout can be overriden

[Copilot]

Pull request overview

Adds a 300-second timeout to prompt subprocess execution and handles timeout failures gracefully.

Changes:

• Passes a timeout to subprocess.run().
• Converts TimeoutExpired into a failed prompt result.

Show a summary per file

File	Description
src/specify_cli/workflows/steps/prompt/__init__.py	Adds prompt execution timeout handling; currently references undefined config.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Medium

[mnriem]

Please address Copilot feedback and fix test & lint errors

[Copilot]

Review details

Comments suppressed due to low confidence (2)

src/specify_cli/workflows/steps/prompt/init.py:200

• Add regression coverage for this timeout path. The existing TestPromptStep dispatch tests neither inspect the timeout argument nor make subprocess.run() raise TimeoutExpired, so they would still pass if the configured/default timeout were dropped or this handler returned the wrong result. Cover the 300-second default, a custom value, and the failed StepResult/message on expiry.

        except subprocess.TimeoutExpired:
            return {
                "exit_code": -1,
                "stdout": "",
                "stderr": f"Prompt timed out after {timeout} seconds.",

src/specify_cli/workflows/steps/prompt/init.py:92

• Validate timeout before dispatching, matching ShellStep. As written, timeout: null is passed as None and disables the timeout entirely, while values such as "30" or .inf can raise from subprocess.run() and abort the workflow; booleans are also silently treated as numeric durations. Require a positive, finite non-boolean number in both validate() and execute(), returning a failed StepResult when execution bypasses validation.

This issue also appears on line 196 of the same file.

        timeout = config.get("timeout", 300)

• Files reviewed: 1/1 changed files
• Comments generated: 0 new
• Review effort level: Medium

[mnriem]

Thank you!