fix: eliminate TOCTOU race in file unlink calls - #3819
Merged
mnriem merged 1 commit intoJul 31, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Eliminates TOCTOU races by using atomic, missing-tolerant unlink operations.
Changes:
- Removes existence checks before deleting integration metadata.
- Applies the same fix to extension cache files.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/_helpers.py |
Safely removes integration.json. |
src/specify_cli/extensions/__init__.py |
Safely clears cache and metadata files. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Medium
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace if path.exists(): path.unlink() with path.unlink(missing_ok=True) in extensions/init.py clear_cache and integrations/_helpers.py to eliminate TOCTOU race conditions.