fix: use missing_ok=True in extension ZIP cleanup - #3870
Merged
mnriem merged 1 commit intoSep 1, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces TOCTOU-prone ZIP existence checks with atomic, tolerant cleanup.
Changes:
- Uses
Path.unlink(missing_ok=True)in both extension ZIP cleanup paths.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/extensions/_commands.py |
Makes temporary ZIP cleanup race-safe. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
mnriem
requested changes
Aug 7, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please resolve conflicts and pull in upstream/main
Replace check-then-act pattern with unlink(missing_ok=True) to eliminate TOCTOU race condition in finally blocks.
Quratulain-bilal
force-pushed
the
fix/extensions-commands-toctou
branch
from
August 7, 2026 20:30
83a66f9 to
74254a6
Compare
mnriem
self-requested a review
September 1, 2026 21:30
mnriem
approved these changes
Sep 1, 2026
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace check-then-act pattern with unlink(missing_ok=True) to eliminate TOCTOU race condition in finally blocks.