Clarify custom checklist ownership and lifecycle - #4028
Open
WOLIKIMCHENG wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies ownership and lifecycle semantics for custom versus built-in checklists.
Changes:
- Defines custom checklists as reviewer-owned requirements-quality artifacts.
- Makes implementation treat checklist markers as read-only gates.
- Documents distinct built-in
requirements.mdbehavior.
Show a summary per file
| File | Description |
|---|---|
docs/quickstart.md |
Updates checklist and implementation guidance. |
docs/reference/agentic-sdd.md |
Documents ownership and lifecycle distinctions. |
templates/commands/checklist.md |
Adds reviewer ownership rules. |
templates/checklist-template.md |
Defines checkbox semantics and lifecycle notes. |
templates/commands/implement.md |
Makes checklist state read-only during implementation. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
| ### Step 8: `/speckit.implement` — build it | ||
|
|
||
| Executes the tasks in `tasks.md` in dependency order. Run it once to build everything, or scope it to one phase at a time for large features. | ||
| Executes the tasks in `tasks.md` in dependency order. Before implementation, it reads checklist checkbox state as a gate and asks before proceeding if any checklist items are unchecked; it does not change custom checklist markers. Run it once to build everything, or scope it to one phase at a time for large features. |
mnriem
requested changes
Aug 10, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/speckit.checklistoutputs are reviewer-owned requirements-quality artifacts.[x]markers as requirements-quality approval, not implementation completion./speckit.implementguidance to treat checklist markers as a read-only gate and distinguish the built-inchecklists/requirements.mdlifecycle.Closes #3979
Validation
git diff --check -- docs/quickstart.md docs/reference/agentic-sdd.md templates/commands/checklist.md templates/checklist-template.md templates/commands/implement.mdPYTHONDONTWRITEBYTECODE=1 .venv/bin/python -m pytest -p no:cacheprovider tests/test_command_template_py_scripts.py -q