Skip to content

fix(bundler): reject unsupported catalog payload versions - #4090

Merged
mnriem merged 3 commits into
github:mainfrom
marcelsafin:fix/bundle-catalog-payload-schema-version
Sep 1, 2026
Merged

fix(bundler): reject unsupported catalog payload versions#4090
mnriem merged 3 commits into
github:mainfrom
marcelsafin:fix/bundle-catalog-payload-schema-version

Conversation

@marcelsafin

Copy link
Copy Markdown
Contributor

Description

Bundle catalog payloads can declare schema_version, but the loader currently ignores it and parses future incompatible formats under current assumptions.

This rejects unsupported major versions before reading entries. Payloads without a version remain accepted for backward compatibility, and compatible 1.x payloads retain current behavior.

Testing

  • Tested locally with uv run specify --help
  • Ran existing tests with uv sync && uv run pytest (6,652 passed, 177 skipped)
  • Added a contract regression for an unsupported 2.0 payload
  • uvx ruff@0.15.0 check src tests clean

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (describe below)

Implemented autonomously by GitHub Copilot CLI (model: GPT-5.6 Sol) under human direction; a failing contract regression was added before the fix, then the full suite and lint were run locally. Commit includes Assisted-by and Co-authored-by trailers.

Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 12, 2026 22:05
@marcelsafin
marcelsafin requested a review from mnriem as a code owner August 12, 2026 22:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Rejects incompatible bundle catalog schema versions while preserving support for versionless and 1.x payloads.

Changes:

  • Adds catalog schema major-version validation.
  • Adds a regression test for unsupported 2.0 payloads.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/specify_cli/bundler/models/catalog.py Validates catalog payload schema versions before parsing entries.
tests/contract/test_catalog_schema.py Tests rejection of unsupported schema versions.

馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread tests/contract/test_catalog_schema.py

@mnriem mnriem left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Copilot feedback

marcelsafin and others added 2 commits August 26, 2026 00:16
Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 25, 2026 22:23
@marcelsafin

Copy link
Copy Markdown
Contributor Author

Addressed the compatibility coverage request on commit 36109406: added acceptance cases for compatible 1.x and absent schema_version payloads, then synced with current main. The full suite passed (6,817 passed, 503 skipped), and repository-pinned Ruff is clean. Posted on behalf of @marcelsafin by GitHub Copilot (model: GPT-5.6 Sol).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃煝 Approval recommended

The implementation matches the stated compatibility behavior and includes focused regression coverage.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@mnriem
mnriem self-requested a review September 1, 2026 20:55
@mnriem
mnriem merged commit d4ba753 into github:main Sep 1, 2026
14 checks passed
@mnriem

mnriem commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants