Fix Korean translation#684
Merged
Merged
Conversation
Fix several questionable vocabulary and grammar choices, forgoing word-for-word translation in favor of preserving the original authors' intentions.
Contributor
|
Hello @pastelmind! Thank you for submitting this fix. I'm working on getting someone who speaks Korean on our team to review this, and once we get some eyes on it, I'll merge it in. |
son7211
reviewed
Jun 20, 2019
son7211
reviewed
Jun 20, 2019
Contributor
|
Fabulous! Thank you so much, @pastelmind and @son7211! ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix several questionable vocabulary and grammar choices, forgoing word-for-word translation in favor of preserving the original authors' intentions.
Overview
The previous Korean translation made use of several questionable terms (often translated word-for-word) that made the cheat sheet unnecessarily obscure. These changes employ words commonly used in Korean docs and discussions regarding Git and GitHub.
Questions
<If relevant, write a list of questions that you would like to discuss related to the changes that you have made.>
Next Steps
<If incomplete, create a task list of items that are still being worked on within the Pull Request.>
Review
<If complete, or ready for 👀, use @mentions for quick questions, specific feedback, and progress updates.>