Conversation
charisk
left a comment
There was a problem hiding this comment.
This is looking great! A partial review from me atm.
extensions/ql-vscode/src/view/variant-analysis/VariantAnalysis.tsx
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisHeader.tsx
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisHeader.tsx
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisHeader.tsx
Show resolved
Hide resolved
extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisHeader.tsx
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisHeader.tsx
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisHeader.tsx
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisHeader.tsx
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysisHeader.spec.tsx
Outdated
Show resolved
Hide resolved
| @@ -1,9 +1,13 @@ | |||
| import styled from 'styled-components'; | |||
There was a problem hiding this comment.
Is it worth moving this file into a shared location (view/common rather than having some stuff in remote-queries and some in variant-analysis)? I'm happy for this to be in a subsequent PR if we agree it's the right thing to do.
There was a problem hiding this comment.
👍, I think that would be very useful. We can also consider making these importable by just specifying the ../common when we place an index.ts file inside the common directory.
There was a problem hiding this comment.
Great! Are you happy to do that as part of the issue you're working on, as a separate PR?
There was a problem hiding this comment.
It might be better to do that in a separate PR. There are some other components which we might also be able to move to the common directory such as VerticalSpace, so the changeset might get quite large (especially since all imports also need to be changed).
There was a problem hiding this comment.
Yeah I'd definitely prefer to see it in a separate PR!
This adds the variant analysis top header. It also adds React testing library to make automated testing of this possible and adds stories for the newly added component.
It might be easier to review this commit-by-commit.
Since this is only part of header, we need a better name for this component. However, I couldn't really think of one. The best one I could come up with is
VariantAnalysisTitleRowbut that doesn't really cover everything.Checklist
ready-for-doc-reviewlabel there.