Skip to content

Move common React components to separate directory#1520

Merged
koesie10 merged 1 commit intomainfrom
koesie10/react-components-common
Sep 20, 2022
Merged

Move common React components to separate directory#1520
koesie10 merged 1 commit intomainfrom
koesie10/react-components-common

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Sep 19, 2022

This moves the common React components between the remote queries and variant analysis views to a common directory, as discussed here.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 requested review from a team as code owners September 19, 2022 08:05
charisk
charisk approved these changes Sep 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying that up!

@koesie10 koesie10 merged commit 64f33a5 into main Sep 20, 2022
@koesie10 koesie10 deleted the koesie10/react-components-common branch September 20, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charisk charisk charisk approved these changes

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koesie10 @charisk @aeisenberg