Merged
Conversation
koesie10
force-pushed
the
koesie10/new-variant-analysis-statuses
branch
from
71d7f16 to
c378d4f
Compare
The `status` on the variant analysis has changed to have `succeeded`, `failed` and `cancelled` instead of `completed`.
koesie10
force-pushed
the
koesie10/new-variant-analysis-statuses
branch
from
c378d4f to
d711d80
Compare
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
I realise the API change isn't it yet, but when it it this change looks good to me.
Will need to also update the alert introduced in #1728 to handle the new failure reason.
…analysis-statuses
This also changes the failure reason alert component to remove the logs button since it's not used by any failure reason. Instead, a link is added into the message for a failed Actions workflow using which the Actions workflow run may be opened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
statuson the variant analysis has changed to havesucceeded,failedandcancelledinstead ofcompleted. This updates the extension to use these statuses as well.Checklist
ready-for-doc-reviewlabel there.