Skip to content

Rename iconPath to icon#1742

Merged
charisk merged 1 commit intomainfrom
charisk/rename-icon-path
Nov 11, 2022
Merged

Rename iconPath to icon#1742
charisk merged 1 commit intomainfrom
charisk/rename-icon-path

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Nov 10, 2022

We don't store a path, but simply the ThemeIcon.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Nov 10, 2022
@charisk charisk requested a review from a team as a code owner November 10, 2022 16:44
@charisk charisk enabled auto-merge (squash) November 10, 2022 16:59
@charisk charisk merged commit 93b6abe into main Nov 11, 2022
@charisk charisk deleted the charisk/rename-icon-path branch November 11, 2022 09:56
charisk added a commit that referenced this pull request Nov 14, 2022
@charisk
Revert "Rename iconPath to icon (#1742)"
d1986b3 
This reverts commit 93b6abe.
charisk added a commit that referenced this pull request Nov 14, 2022
@charisk
Revert "Rename iconPath to icon" (#1764)
3451259 
* Revert "Rename iconPath to icon (#1742)"

This reverts commit 93b6abe.

* Add comment to explain things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @koesie10