Skip to content

Revert "Rename iconPath to icon"#1764

Merged
charisk merged 2 commits intomainfrom
charisk/fix-db-panel-icons
Nov 14, 2022
Merged

Revert "Rename iconPath to icon"#1764
charisk merged 2 commits intomainfrom
charisk/fix-db-panel-icons

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Nov 14, 2022

This reverts commit 93b6abe which has broken the icons in the db panel.

I forgot that we have to use the same name as vscode.TreeItems! 🤦‍♀️

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Nov 14, 2022
@charisk charisk requested a review from a team as a code owner November 14, 2022 15:50
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment that these property names need to match the ones from TreeItem?

@charisk charisk changed the title Revert "Rename iconPath to icon (#1742)" Revert "Rename iconPath to icon" Nov 14, 2022
@charisk charisk enabled auto-merge (squash) November 14, 2022 16:19
@charisk charisk merged commit 3451259 into main Nov 14, 2022
@charisk charisk deleted the charisk/fix-db-panel-icons branch November 14, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants