Skip to content

Check variant analysis status in isVariantAnalysisComplete#1826

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/check_status
Dec 2, 2022
Merged

Check variant analysis status in isVariantAnalysisComplete#1826
robertbrignull merged 1 commit intomainfrom
robertbrignull/check_status

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

This allows us to get out of a state where we think that a variant analysis is still in progress but all of its repo tasks are complete. It is possible for the API to return this state in a temporary edge case when the workflow has just finished, but its not permanent and the API will soon start saying the variant analysis is complete. So in this case we want to continue polling, and if VSCode starts up we want to poll for updated state.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team as a code owner December 2, 2022 12:50
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for figuring out that this could be happening!

@robertbrignull
Copy link
Copy Markdown
Contributor Author

I've managed to reproduce this state a couple of times when the analysis has just finished. I shut down VSCode at that exact moment and it correctly started up the monitor once I started VScode again.

@robertbrignull robertbrignull merged commit 008d7b3 into main Dec 2, 2022
@robertbrignull robertbrignull deleted the robertbrignull/check_status branch December 2, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants