Check variant analysis status in isVariantAnalysisComplete#1826
Merged
robertbrignull merged 1 commit intomainfrom Dec 2, 2022
Merged
Check variant analysis status in isVariantAnalysisComplete#1826robertbrignull merged 1 commit intomainfrom
robertbrignull merged 1 commit intomainfrom
Conversation
koesie10
approved these changes
Dec 2, 2022
Member
koesie10
left a comment
There was a problem hiding this comment.
LGTM, thanks for figuring out that this could be happening!
Contributor
Author
|
I've managed to reproduce this state a couple of times when the analysis has just finished. I shut down VSCode at that exact moment and it correctly started up the monitor once I started VScode again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to get out of a state where we think that a variant analysis is still in progress but all of its repo tasks are complete. It is possible for the API to return this state in a temporary edge case when the workflow has just finished, but its not permanent and the API will soon start saying the variant analysis is complete. So in this case we want to continue polling, and if VSCode starts up we want to poll for updated state.
Checklist
ready-for-doc-reviewlabel there.