Skip to content

Check variant analysis status in isVariantAnalysisComplete #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbrignull merged 1 commit into from
Dec 2, 2022
Merged

Check variant analysis status in isVariantAnalysisComplete #1826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions extensions/ql-vscode/src/remote-queries/shared/variant-analysis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,15 @@ export async function isVariantAnalysisComplete(
repo: VariantAnalysisScannedRepository,
) => Promise<boolean>,
): Promise<boolean> {
// It's only acceptable to have no scanned repos if the variant analysis is not in a final state.
// Otherwise it means the analysis hit some kind of internal error or there were no repos to scan.
if (!isFinalVariantAnalysisStatus(variantAnalysis.status)) {
return false;
}

if (
variantAnalysis.scannedRepos === undefined ||
variantAnalysis.scannedRepos.length === 0
) {
return variantAnalysis.status !== VariantAnalysisStatus.InProgress;
return true;
}

return (
Expand Down