Create "Add database" button in DB panel #1882
Closed
norascheuch wants to merge 1 commit intomainfrom
Closed
Conversation
norascheuch
commented
Dec 16, 2022
shati-patel
reviewed
Dec 16, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thanks! Looks good overall ❤️ Just left some comments that we mostly already talked about 😸
Contributor
Author
|
PR for the refactor: #1888 |
norascheuch
force-pushed
the
shati-nora/add-remote-repos
branch
from
5bb3670 to
7241e31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To add new databases to the new DB panel we want to have an "Add database" button (using the "add" icon), which lets a user add a new database or an owner item through the UI.
Checklist
ready-for-doc-reviewlabel there.