Extract github url identifier helper#1888
Merged
norascheuch merged 1 commit intomainfrom Dec 20, 2022
Merged
Conversation
3 tasks
shati-patel
approved these changes
Dec 20, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Looks good! I've left a few comments, but none of them are blocking 🐻❄️
| } | ||
|
|
||
| /** | ||
| * Extracts an NOW from a GitHub URL. |
Contributor
There was a problem hiding this comment.
Minor :)
Suggested change
| * Extracts an NOW from a GitHub URL. | |
| * Extracts an NWO from a GitHub URL. |
| * @param identifier The GitHub NWO | ||
| * @returns | ||
| */ | ||
| export function validGitHubNwo(identifier: string): boolean { |
Contributor
There was a problem hiding this comment.
Minor (feel free to ignore if this would make conflicts etc annoying!) 👍🏽
I'd probably name this function "isValid..." since that sounds more like a true/false check. Similar for the other functions :)
Suggested change
| export function validGitHubNwo(identifier: string): boolean { | |
| export function isValidGitHubNwo(identifier: string): boolean { |
| } | ||
|
|
||
| if (!looksLikeGithubRepo(githubRepo)) { | ||
| const nwo = getNwoFromGitHubUrl(githubRepo) || githubRepo; |
Contributor
There was a problem hiding this comment.
Thanks for tidying up this section! 🧹
Contributor
Author
|
I will implement both changes in the "Add database" button PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up how we validate github owner and NWOs as well as refactors a bit of the flow surrounding the current usage of the helper.
Checklist
ready-for-doc-reviewlabel there.