Skip to content

Removed unnecessary awaits#1982

Merged
charisk merged 1 commit intomainfrom
charisk/remove-unnecessary-awaits
Jan 18, 2023
Merged

Removed unnecessary awaits#1982
charisk merged 1 commit intomainfrom
charisk/remove-unnecessary-awaits

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jan 18, 2023

The functions are synchronous so they don't need to be awaited.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Jan 18, 2023
@charisk charisk requested a review from a team as a code owner January 18, 2023 10:26
@robertbrignull
Copy link
Copy Markdown
Contributor

robertbrignull commented Jan 18, 2023

There's a rule for this: https://typescript-eslint.io/rules/await-thenable

It seems we already use @typescript-eslint/recommended so maybe adding this one from typescript-eslint would be hard.

@charisk charisk enabled auto-merge (squash) January 18, 2023 10:47
@charisk charisk merged commit ec1cf01 into main Jan 18, 2023
@charisk charisk deleted the charisk/remove-unnecessary-awaits branch January 18, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @robertbrignull