Skip to content

Removed unnecessary awaits #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charisk merged 1 commit into from
Jan 18, 2023
Merged

Removed unnecessary awaits #1982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 10 additions & 23 deletions extensions/ql-vscode/test/unit-tests/databases/config/db-config-store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ describe("db config store", () => {
const configStore = await initializeConfig(dbConfig, configPath, app);

// Check
const doesExist = await configStore.doesRemoteOwnerExist("owner1");
const doesExist = configStore.doesRemoteOwnerExist("owner1");
expect(doesExist).toEqual(true);

configStore.dispose();
Expand All @@ -697,7 +697,7 @@ describe("db config store", () => {
const configStore = await initializeConfig(dbConfig, configPath, app);

// Check
const doesExist = await configStore.doesRemoteListExist("list1");
const doesExist = configStore.doesRemoteListExist("list1");
expect(doesExist).toEqual(true);

configStore.dispose();
Expand All @@ -717,10 +717,7 @@ describe("db config store", () => {
const configStore = await initializeConfig(dbConfig, configPath, app);

// Check
const doesExist = await configStore.doesRemoteDbExist(
"owner/repo1",
"list1",
);
const doesExist = configStore.doesRemoteDbExist("owner/repo1", "list1");
expect(doesExist).toEqual(true);

configStore.dispose();
Expand All @@ -740,9 +737,9 @@ describe("db config store", () => {
const configStore = await initializeConfig(dbConfig, configPath, app);

// Check
const doesDbExist = await configStore.doesLocalDbExist("db1", "list1");
const doesDbExist = configStore.doesLocalDbExist("db1", "list1");
expect(doesDbExist).toEqual(true);
const doesListExist = await configStore.doesLocalListExist("list1");
const doesListExist = configStore.doesLocalListExist("list1");
expect(doesListExist).toEqual(true);

configStore.dispose();
Expand All @@ -755,25 +752,15 @@ describe("db config store", () => {
const configStore = await initializeConfig(dbConfig, configPath, app);

// Check
const doesLocalDbExist = await configStore.doesLocalDbExist(
"db1",
"list1",
);
const doesLocalDbExist = configStore.doesLocalDbExist("db1", "list1");
expect(doesLocalDbExist).toEqual(false);
const doesLocalListExist = await configStore.doesLocalListExist("list1");
const doesLocalListExist = configStore.doesLocalListExist("list1");
expect(doesLocalListExist).toEqual(false);
const doesRemoteDbExist = await configStore.doesRemoteDbExist(
"db1",
"list1",
);
const doesRemoteDbExist = configStore.doesRemoteDbExist("db1", "list1");
expect(doesRemoteDbExist).toEqual(false);
const doesRemoteListExist = await configStore.doesRemoteListExist(
"list1",
);
const doesRemoteListExist = configStore.doesRemoteListExist("list1");
expect(doesRemoteListExist).toEqual(false);
const doesRemoteOwnerExist = await configStore.doesRemoteOwnerExist(
"owner1",
);
const doesRemoteOwnerExist = configStore.doesRemoteOwnerExist("owner1");
expect(doesRemoteOwnerExist).toEqual(false);

configStore.dispose();
Expand Down