Skip to content

Remove some as unknown as X usages#2067

Merged
charisk merged 1 commit intomainfrom
charisk/remove-unnecessary-castings
Feb 13, 2023
Merged

Remove some as unknown as X usages#2067
charisk merged 1 commit intomainfrom
charisk/remove-unnecessary-castings

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Feb 13, 2023

These castings weren't necessary.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Feb 13, 2023
@charisk charisk requested review from a team as code owners February 13, 2023 12:31
koesie10
koesie10 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I believe these were necessary before, but that might have been changed when some of the TypeScript configs were changed.

@charisk charisk enabled auto-merge (squash) February 13, 2023 12:43
@charisk charisk merged commit f7826c3 into main Feb 13, 2023
@charisk charisk deleted the charisk/remove-unnecessary-castings branch February 13, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @koesie10