Skip to content

Remove some as unknown as X usages #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charisk merged 1 commit into from
Feb 13, 2023
Merged

Remove some as unknown as X usages #2067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/ql-vscode/src/stories/variant-analysis/RepoRow.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,15 +124,15 @@ InterpretedResults.args = {
resultCount: 198,
interpretedResults: analysesResults.analysesResults.find(
(v) => v.nwo === "facebook/create-react-app",
)?.interpretedResults as unknown as AnalysisAlert[],
)?.interpretedResults as AnalysisAlert[],
};

export const RawResults = Template.bind({});
RawResults.args = {
...InterpretedResults.args,
interpretedResults: undefined,
resultCount: 1,
rawResults: rawResults as unknown as AnalysisRawResults,
rawResults: rawResults as AnalysisRawResults,
};

export const SkippedOnlyFullName = Template.bind({});
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/stories/variant-analysis/VariantAnalysisAnalyzedRepos.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const interpretedResultsForRepo = (
nwo: string,
): AnalysisAlert[] | undefined => {
return analysesResults.analysesResults.find((v) => v.nwo === nwo)
?.interpretedResults as unknown as AnalysisAlert[];
?.interpretedResults as AnalysisAlert[];
};

export const Example = Template.bind({});
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/common/CodePaths/CodeFlowsDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const CodeFlowsDropdown = ({
return (
<VSCodeDropdown
onChange={
handleChange as unknown as ((e: Event) => unknown) &
handleChange as ((e: Event) => unknown) &
React.FormEventHandler<HTMLElement>
}
>
Expand Down