Extension Telemetry: Split runVariantAnalysis and viewAst command#2142
Merged
norascheuch merged 2 commits intomainfrom Mar 10, 2023
Merged
Extension Telemetry: Split runVariantAnalysis and viewAst command#2142norascheuch merged 2 commits intomainfrom
runVariantAnalysis and viewAst command#2142norascheuch merged 2 commits intomainfrom
Conversation
norascheuch
force-pushed
the
nora/split-commands-a
branch
from
e99b764 to
d1d473e
Compare
Contributor
elenatanasoiu
left a comment
elenatanasoiu
left a comment
There was a problem hiding this comment.
Looks good!
I had one small comment: could we make it clear the reason we're splitting these commands up is for telemetry? It's unclear from the PR description which user behaviour we mean to track.
Perhaps the PR description or the commit (or both!) can be changed to mention this.
elenatanasoiu
approved these changes
Mar 8, 2023
3 tasks
norascheuch
force-pushed
the
nora/split-commands-a
branch
from
d1d473e to
e9f9f71
Compare
3 tasks
norascheuch
force-pushed
the
nora/split-commands-a
branch
from
e9f9f71 to
7f32439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we track usage behaviour by command usage at the moment, we have to use different commands for different user interactions. Each command has to be unique. Even if the underlying behaviour in the extension is identical.
Checklist
ready-for-doc-reviewlabel there.