Extension Telemetry: Split viewCfg,quickEval, openReferencedFile command#2154
Merged
norascheuch merged 5 commits intomainfrom Mar 10, 2023
Merged
Extension Telemetry: Split viewCfg,quickEval, openReferencedFile command#2154norascheuch merged 5 commits intomainfrom
viewCfg,quickEval, openReferencedFile command#2154norascheuch merged 5 commits intomainfrom
Conversation
robertbrignull
approved these changes
Mar 9, 2023
| "when": "editorLangId == ql && resourceExtname == .ql" | ||
| }, | ||
| { | ||
| "command": "codeQL.exportSelectedVariantAnalysisResults" |
Contributor
There was a problem hiding this comment.
Just so I understand correctly, it's ok to remove codeQL.exportSelectedVariantAnalysisResults from here because it was basically a no-op anyway. Including it in commandPalette without a when field doesn't do anything since it would be included anyway.
norascheuch
force-pushed
the
nora/split-commands-b
branch
from
346ba34 to
c0c7574
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we track usage behaviour by command usage at the moment, we have to use different commands for different user interactions. Each command has to be unique. Even if the underlying behaviour in the extension is identical.
To prevent merge conflicts the branch is based on #2142
Checklist
ready-for-doc-reviewlabel there.