Skip to content

Remove member variables that could be local variables#2443

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/query-constructor
May 24, 2023
Merged

Remove member variables that could be local variables#2443
robertbrignull merged 1 commit intomainfrom
robertbrignull/query-constructor

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

Just noticed we currently don't use any of these variables outside of the constructor, so they don't technically have to be member variables. We could make them local variables instead and I think this makes things a bit cleaner.

What do you think? We can always change them back to member variables if we need them again in the future.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team May 24, 2023 09:41
@robertbrignull robertbrignull requested a review from a team as a code owner May 24, 2023 09:41
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robertbrignull robertbrignull merged commit 5d7a723 into main May 24, 2023
@robertbrignull robertbrignull deleted the robertbrignull/query-constructor branch May 24, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants