Remove member variables that could be local variables#2443
Merged
robertbrignull merged 1 commit intomainfrom May 24, 2023
Merged
Remove member variables that could be local variables#2443robertbrignull merged 1 commit intomainfrom
robertbrignull merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just noticed we currently don't use any of these variables outside of the constructor, so they don't technically have to be member variables. We could make them local variables instead and I think this makes things a bit cleaner.
What do you think? We can always change them back to member variables if we need them again in the future.
Checklist
ready-for-doc-reviewlabel there.