Skip to content

Remove member variables that could be local variables #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbrignull merged 1 commit into from
May 24, 2023
Merged

Remove member variables that could be local variables #2443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions extensions/ql-vscode/src/queries-panel/queries-module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ import { QueriesPanel } from "./queries-panel";
import { QueryDiscovery } from "./query-discovery";

export class QueriesModule extends DisposableObject {
private queriesPanel: QueriesPanel | undefined;
private queryDiscovery: QueryDiscovery | undefined;

private constructor(readonly app: App) {
super();
}
Expand All @@ -22,12 +19,12 @@ export class QueriesModule extends DisposableObject {
}
void extLogger.log("Initializing queries panel.");

this.queryDiscovery = new QueryDiscovery(app, cliServer);
this.push(this.queryDiscovery);
this.queryDiscovery.refresh();
const queryDiscovery = new QueryDiscovery(app, cliServer);
this.push(queryDiscovery);
queryDiscovery.refresh();

this.queriesPanel = new QueriesPanel(this.queryDiscovery);
this.push(this.queriesPanel);
const queriesPanel = new QueriesPanel(queryDiscovery);
this.push(queriesPanel);
}

public static initialize(
Expand Down
13 changes: 4 additions & 9 deletions extensions/ql-vscode/src/queries-panel/queries-panel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,17 @@
import * as vscode from "vscode";
import { DisposableObject } from "../pure/disposable-object";
import { QueryTreeDataProvider } from "./query-tree-data-provider";
import { QueryTreeViewItem } from "./query-tree-view-item";
import { QueryDiscovery } from "./query-discovery";

export class QueriesPanel extends DisposableObject {
private readonly dataProvider: QueryTreeDataProvider;
private readonly treeView: vscode.TreeView<QueryTreeViewItem>;

public constructor(queryDiscovery: QueryDiscovery) {
super();

this.dataProvider = new QueryTreeDataProvider(queryDiscovery);
const dataProvider = new QueryTreeDataProvider(queryDiscovery);

this.treeView = vscode.window.createTreeView("codeQLQueries", {
treeDataProvider: this.dataProvider,
const treeView = vscode.window.createTreeView("codeQLQueries", {
treeDataProvider: dataProvider,
});

this.push(this.treeView);
this.push(treeView);
}
}