Skip to content

Add locale to toLocaleLowerCase calls#2488

Merged
koesie10 merged 1 commit intomainfrom
koesie10/fix-locale-lower-case
Jun 8, 2023
Merged

Add locale to toLocaleLowerCase calls#2488
koesie10 merged 1 commit intomainfrom
koesie10/fix-locale-lower-case

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Jun 7, 2023

This adds the locale to all toLocaleLowerCase calls. The three calls to toLocaleLowerCase were all very similar, so I've created a function to abstract this behavior. Now, we only have 1 call to toLocaleLowerCase and have simplified the logic for checking environment variables.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 added the secexp label Jun 7, 2023
@koesie10 koesie10 requested a review from a team June 7, 2023 12:52
@koesie10 koesie10 marked this pull request as ready for review June 7, 2023 13:43
@koesie10 koesie10 requested a review from a team as a code owner June 7, 2023 13:43
@koesie10 koesie10 merged commit 8db5c6d into main Jun 8, 2023
@koesie10 koesie10 deleted the koesie10/fix-locale-lower-case branch June 8, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants