Skip to content

Add locale to toLocaleLowerCase calls #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koesie10 merged 1 commit into from
Jun 8, 2023
+11 −14
Merged

Add locale to toLocaleLowerCase calls #2488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions extensions/ql-vscode/src/codeql-cli/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,28 +1756,25 @@ async function logStream(stream: Readable, logger: BaseLogger): Promise<void> {
}
}

export function shouldDebugIdeServer() {
function isEnvTrue(name: string): boolean {
return (
"IDE_SERVER_JAVA_DEBUG" in process.env &&
process.env.IDE_SERVER_JAVA_DEBUG !== "0" &&
process.env.IDE_SERVER_JAVA_DEBUG?.toLocaleLowerCase() !== "false"
name in process.env &&
process.env[name] !== "0" &&
// Use en-US since we expect the value to be either "false" or "FALSE", not a localized version.
process.env[name]?.toLocaleLowerCase("en-US") !== "false"
);
}

export function shouldDebugIdeServer() {
return isEnvTrue("IDE_SERVER_JAVA_DEBUG");
}

export function shouldDebugQueryServer() {
return (
"QUERY_SERVER_JAVA_DEBUG" in process.env &&
process.env.QUERY_SERVER_JAVA_DEBUG !== "0" &&
process.env.QUERY_SERVER_JAVA_DEBUG?.toLocaleLowerCase() !== "false"
);
return isEnvTrue("QUERY_SERVER_JAVA_DEBUG");
}

export function shouldDebugCliServer() {
return (
"CLI_SERVER_JAVA_DEBUG" in process.env &&
process.env.CLI_SERVER_JAVA_DEBUG !== "0" &&
process.env.CLI_SERVER_JAVA_DEBUG?.toLocaleLowerCase() !== "false"
);
return isEnvTrue("CLI_SERVER_JAVA_DEBUG");
}

export class CliVersionConstraint {
Expand Down