Skip to content

Data extensions editor: Update styling of "unsaved" tag#2587

Merged
shati-patel merged 2 commits intomainfrom
shati-patel/unsaved-tag
Jul 7, 2023
Merged

Data extensions editor: Update styling of "unsaved" tag#2587
shati-patel merged 2 commits intomainfrom
shati-patel/unsaved-tag

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel commented Jul 6, 2023

Some minor adjustments to the saved/unsaved buttons:
screenshot of library row

  • Uses the "VS Code Tag" from the UI toolkit for the "UNSAVED" label
  • Moves the "Save" button further away from the border

Checklist

N/A—internal only 🎃

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel requested a review from a team as a code owner July 6, 2023 15:38
robertbrignull
robertbrignull approved these changes Jul 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👩🏼‍🎨

@shati-patel shati-patel enabled auto-merge July 6, 2023 15:46
@robertbrignull robertbrignull mentioned this pull request Jul 6, 2023
Merged
3 tasks
@shati-patel shati-patel merged commit 8fab24f into main Jul 7, 2023
@shati-patel shati-patel deleted the shati-patel/unsaved-tag branch July 7, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charisk charisk charisk approved these changes

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shati-patel @charisk @robertbrignull