Use better colours for title buttons#2589
Merged
robertbrignull merged 2 commits intomainfrom Jul 7, 2023
Merged
Conversation
robertbrignull
force-pushed
the
robertbrignull/data-title-buttons-background
branch
from
47febbc to
8036d43
Compare
robertbrignull
force-pushed
the
robertbrignull/data-title-buttons-background
branch
from
8036d43 to
7bda763
Compare
Contributor
Author
|
This might conflict with #2587 but let's merge that PR first and I'll deal with the conflicts here. |
charisk
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes these buttons to use
appearance='icon'instead of custom styling.Light mode (showing hovering and non-hovering):
Dark mode (showing hovering and non-hovering):
Checklist
ready-for-doc-reviewlabel there.